Inconsistent broken robot interaction

[Decker]

This is more a nitpick than a bug.

In the caves, there are often broken robots that can be stripped for pieces. In half the cases, bumping into them with melee results in "cannot swap with disabled ally". They're not disabled, they're broken. Thus, the expected behavior would be for them to be attacked, rather than requiring the player to disable all weapons but melee, and fire the melee weapon manually.

[Kyzrati]

I'm familiar with this one, since I've had the same happen and fixed a similar issue before as more and more types of disabled/broken robot statuses were added.

It's somewhat complicated because in addition to their status there is also a faction setting that you cannot see, and that's what really determines attempted swap behavior. That particular bot you're looking at is created as an ally (albeit a permanently broken one). Broken status should override swapping when it comes to bump behavior, but there was... some reason I didn't do that in there . I'll check again to see if I can make it more convenient!

[Kyzrati]

Okay, I've fixed these without changing the overall behavior. What was really needed was to make sure that prefab-placed broken robots were not assigned to an allied faction. I'd assigned them factions based on their origin, but that doesn't make sense in some cases you run across in the caves since they're permanently broken anyway (and yes, meant for you to scavenge parts from ).